Wagtail 2.12 compatibility #170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current Python versions as of February 2021 no longer treat the ; character as a URL parameter separator: https://python-security.readthedocs.io/vuln/urllib-query-string-semicolon-separator.html This breaks the tests for the url_replace tag, as they attempt to parse a URL generated by a Django template. HTML autoescaping is enabled, so & characters in the URL will be escaped as &. This discrepancy between escaped and unescaped HTML was previously masked because the closing ; was also treated as a separator.
On Wagtail 2.12, switch to using raw_data in place of the deprecated stream_data. Switching to indexing the stream directly as a list (as per https://docs.wagtail.io/en/stable/releases/2.12.html#stream-data-on-streamfield-values-is-deprecated) is not really feasible here, as this would change public APIs that expect the JSON representation (e.g. https://wagtailstreamforms.readthedocs.io/en/latest/fields.html)
Codecov Report
@@ Coverage Diff @@
## master #170 +/- ##
==========================================
+ Coverage 95.63% 95.65% +0.01%
==========================================
Files 28 28
Lines 940 943 +3
Branches 84 85 +1
==========================================
+ Hits 899 902 +3
Misses 34 34
Partials 7 7
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #167