This repository has been archived by the owner on Apr 24, 2024. It is now read-only.
Improvements to Ridge #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PicoCentauri
force-pushed
the
ridge_impros
branch
from
2c7322d
to
0745776
Compare
DavideTisi
reviewed
Feb 15, 2023
* Move `alpha` and `rcond` into fit method * Allow floats in addition to a TensorMap as `alpha` parameter * Various improvements to the docstring and example
PicoCentauri
force-pushed
the
ridge_impros
branch
from
0745776
to
cb11ba5
Compare
DavideTisi
approved these changes
Feb 15, 2023
Luthaf
reviewed
Feb 20, 2023
| # ``"positions"`` (forces). | ||
|
|
||
|
|
||
| clf = Ridge(parameter_keys=["values", "positions"]) |
There was a problem hiding this comment.
Quick question: this parameter_keys is here to allow training of a model using only gradients, right? otherwise it feels a bit redundant: one could say we use everything defined on the input tensormap
This was referenced Mar 1, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is factoring out the improvements to
Ridgestarted in #10. It contains the following changes.alphaandrcondinto fit methodcoefattribute toweightsto be consistent with documentation.alphaparameter