Skip to content

feat(plugin): add async io for the plugin #560

feat(plugin): add async io for the plugin

feat(plugin): add async io for the plugin #560

GitHub Actions / clippy succeeded Mar 24, 2024 in 0s

clippy

20 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 20
Note 0
Help 0

Versions

  • rustc 1.77.0 (aedd173a2 2024-03-17)
  • cargo 1.77.0 (3fe68eabf 2024-02-29)
  • clippy 0.1.77 (aedd173 2024-03-17)

Annotations

Check warning on line 47 in tests/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

returning the result of a `let` binding from a block

warning: returning the result of a `let` binding from a block
  --> tests/src/lib.rs:47:9
   |
46 |         let cln = async_run!(cln::Node::with_params("--developer", "regtest")).unwrap();
   |         -------------------------------------------------------------------------------- unnecessary `let` binding
47 |         cln
   |         ^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
help: return the expression directly
   |
46 ~         
47 ~         async_run!(cln::Node::with_params("--developer", "regtest")).unwrap()
   |

Check warning on line 40 in tests/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

returning the result of a `let` binding from a block

warning: returning the result of a `let` binding from a block
  --> tests/src/lib.rs:40:9
   |
39 | ...   let cln = async_run!(cln::Node::with_params(&format!("--developer --plugin={pwd}/target/debug/examples/foo_plugin --plugin={pwd}/target/debug/examples/macros_ex"), "regtest")).unwrap();
   |       ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- unnecessary `let` binding
40 | ...   cln
   |       ^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
   = note: `#[warn(clippy::let_and_return)]` on by default
help: return the expression directly
   |
39 ~         
40 ~         async_run!(cln::Node::with_params(&format!("--developer --plugin={pwd}/target/debug/examples/foo_plugin --plugin={pwd}/target/debug/examples/macros_ex"), "regtest")).unwrap()
   |

Check warning on line 85 in testing/src/cln.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

usage of an `Arc` that is not `Send` and `Sync`

warning: usage of an `Arc` that is not `Send` and `Sync`
  --> testing/src/cln.rs:85:19
   |
85 |         let btc = Arc::new(btc);
   |                   ^^^^^^^^^^^^^
   |
   = note: `Arc<BtcNode>` is not `Send` and `Sync` as:
   = note: - the trait `Sync` is not implemented for `BtcNode`
   = help: consider using an `Rc` instead. `Arc` does not provide benefits for non `Send` and `Sync` types
   = note: if you intend to use `Arc` with `Send` and `Sync` traits
   = note: wrap the inner type with a `Mutex` or implement `Send` and `Sync` for `BtcNode`
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync
   = note: `#[warn(clippy::arc_with_non_send_sync)]` on by default

Check warning on line 120 in testing/src/btc.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this `RefCell` reference is held across an `await` point

warning: this `RefCell` reference is held across an `await` point
   --> testing/src/btc.rs:120:24
    |
120 |         for process in self.process.borrow_mut().iter_mut() {
    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: ensure the reference is dropped before calling `await`
note: these are all the `await` points this reference is held through
   --> testing/src/btc.rs:121:28
    |
121 |             process.kill().await?;
    |                            ^^^^^
122 |             let _ = process.wait().await?;
    |                                    ^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#await_holding_refcell_ref
    = note: `#[warn(clippy::await_holding_refcell_ref)]` on by default

Check warning on line 32 in testing/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

`crate` references the macro call's crate

warning: `crate` references the macro call's crate
  --> testing/src/lib.rs:32:17
   |
32 |             use crate::DEFAULT_TIMEOUT;
   |                 ^^^^^ help: to reference the macro definition's crate, use: `$crate`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#crate_in_macro_def
   = note: `#[warn(clippy::crate_in_macro_def)]` on by default

Check warning on line 30 in plugin/src/types.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this `let...else` may be rewritten with the `?` operator

warning: this `let...else` may be rewritten with the `?` operator
  --> plugin/src/types.rs:28:9
   |
28 | /         let Some(ref value) = self.value else {
29 | |             return None;
30 | |         };
   | |__________^ help: replace it with: `let ref value = self.value?;`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
   = note: `#[warn(clippy::question_mark)]` on by default

Check warning on line 295 in plugin/src/plugin.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unneeded `return` statement

warning: unneeded `return` statement
   --> plugin/src/plugin.rs:295:17
    |
295 |                 return String::new();
    |                 ^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
    |
295 -                 return String::new();
295 +                 String::new()
    |

Check warning on line 290 in plugin/src/plugin.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unneeded `return` statement

warning: unneeded `return` statement
   --> plugin/src/plugin.rs:290:17
    |
290 |                 return serde_json::to_string(&rpc_response).unwrap();
    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
    = note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
    |
290 -                 return serde_json::to_string(&rpc_response).unwrap();
290 +                 serde_json::to_string(&rpc_response).unwrap()
    |

Check warning on line 146 in plugin/src/plugin.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)`

warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)`
   --> plugin/src/plugin.rs:146:25
    |
146 |             "string" => def_val.and_then(|val| Some(serde_json::json!(val))),
    |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `def_val.map(|val| serde_json::json!(val))`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map

Check warning on line 145 in plugin/src/plugin.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)`

warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)`
   --> plugin/src/plugin.rs:145:22
    |
145 |             "int" => def_val.and_then(|val| Some(serde_json::json!(val.parse::<i64>().unwrap()))),
    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `def_val.map(|val| serde_json::json!(val.parse::<i64>().unwrap()))`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map

Check warning on line 143 in plugin/src/plugin.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)`

warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)`
   --> plugin/src/plugin.rs:143:17
    |
143 |                 def_val.and_then(|val| Some(serde_json::json!(val.parse::<bool>().unwrap())))
    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `def_val.map(|val| serde_json::json!(val.parse::<bool>().unwrap()))`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map
    = note: `#[warn(clippy::bind_instead_of_map)]` on by default

Check warning on line 54 in plugin/src/plugin.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

very complex type used. Consider factoring parts into `type` definitions

warning: very complex type used. Consider factoring parts into `type` definitions
  --> plugin/src/plugin.rs:54:14
   |
54 |     on_init: Option<Arc<dyn Fn(&mut Plugin<T>) -> Value>>,
   |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity

Check warning on line 37 in plugin/src/io.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

methods called `into_*` usually take `self` by value

warning: methods called `into_*` usually take `self` by value
  --> plugin/src/io.rs:37:50
   |
37 |     pub fn into_loop<F: FnMut(String) -> String>(&mut self, mut async_callback: F) {
   |                                                  ^^^^^^^^^
   |
   = help: consider choosing a less ambiguous name
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
   = note: `#[warn(clippy::wrong_self_convention)]` on by default

Check warning on line 27 in plugin/src/commands/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'c

warning: the following explicit lifetimes could be elided: 'c
  --> plugin/src/commands/mod.rs:27:18
   |
27 |     fn call_void<'c>(&self, _plugin: &mut Plugin<T>, _request: &'c serde_json::Value) {}
   |                  ^^                                             ^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
   = note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
   |
27 -     fn call_void<'c>(&self, _plugin: &mut Plugin<T>, _request: &'c serde_json::Value) {}
27 +     fn call_void(&self, _plugin: &mut Plugin<T>, _request: &serde_json::Value) {}
   |

Check warning on line 18 in plugin/src/commands/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this lifetime isn't used in the function definition

warning: this lifetime isn't used in the function definition
  --> plugin/src/commands/mod.rs:18:13
   |
18 |     fn call<'c>(
   |             ^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
   = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default

Check warning on line 54 in plugin/src/commands/builtin.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

very complex type used. Consider factoring parts into `type` definitions

warning: very complex type used. Consider factoring parts into `type` definitions
  --> plugin/src/commands/builtin.rs:54:25
   |
54 |     pub(crate) on_init: Option<Arc<dyn Fn(&mut Plugin<T>) -> Value>>,
   |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
   = note: `#[warn(clippy::type_complexity)]` on by default

Check warning on line 39 in plugin_macros/src/attr_parser.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

single-character string constant used as pattern

warning: single-character string constant used as pattern
  --> plugin_macros/src/attr_parser.rs:39:47
   |
39 |         let value = value.to_string().replace("\"", "");
   |                                               ^^^^ help: consider using a `char`: `'"'`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
   = note: `#[warn(clippy::single_char_pattern)]` on by default

Check warning on line 71 in plugin_macros/src/plugin.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this `impl` can be derived

warning: this `impl` can be derived
  --> plugin_macros/src/plugin.rs:61:1
   |
61 | / impl Default for PluginDeclaration {
62 | |     fn default() -> Self {
63 | |         Self {
64 | |             state: None,
...  |
70 | |     }
71 | | }
   | |_^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
   = note: `#[warn(clippy::derivable_impls)]` on by default
   = help: remove the manual implementation...
help: ...and instead derive it
   |
9  + #[derive(Default)]
10 | pub struct PluginDeclaration {
   |

Check warning on line 45 in plugin_macros/src/plugin.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
  --> plugin_macros/src/plugin.rs:45:47
   |
45 |             let mut inner = KTokenStream::new(&inner);
   |                                               ^^^^^^ help: change this to: `inner`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 30 in plugin_macros/src/plugin.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
  --> plugin_macros/src/plugin.rs:30:47
   |
30 |             let mut inner = KTokenStream::new(&inner);
   |                                               ^^^^^^ help: change this to: `inner`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
   = note: `#[warn(clippy::needless_borrow)]` on by default