Sanity Check codebase

fixup! plugin: allow to exectute in an async way #590

Triggered via push April 7, 2024 15:53

vincenzopalazzo

pushed 1dab7b0

macros/async-execution-log

Status Failure

Total duration 57s

Artifacts –

build.yml

on: push

Lints

23s

Matrix: Build

Annotations

4 errors and 64 warnings

the method `flush` exists for struct `Stdout`, but its trait bounds were not satisfied: plugin/src/plugin.rs#L87

error[E0599]: the method `flush` exists for struct `Stdout`, but its trait bounds were not satisfied --> plugin/src/plugin.rs:87:20 | 87 | writer.flush().unwrap(); | ^^^^^ method cannot be called on `Stdout` due to unsatisfied trait bounds | = note: the following trait bounds were not satisfied: `std::io::Stdout: tokio::io::AsyncWrite` which is required by `std::io::Stdout: tokio::io::AsyncWriteExt` = help: items from traits can only be used if the trait is in scope help: the following trait is implemented but not in scope; perhaps add a `use` for it: | 4 + use std::io::Write; |

the method `write_all` exists for struct `Stdout`, but its trait bounds were not satisfied: plugin/src/plugin.rs#L85

error[E0599]: the method `write_all` exists for struct `Stdout`, but its trait bounds were not satisfied --> plugin/src/plugin.rs:85:18 | 84 | / writer 85 | | .write_all(serde_json::to_string(&request).unwrap().as_bytes()) | | -^^^^^^^^^ method cannot be called on `Stdout` due to unsatisfied trait bounds | |_________________| | | = note: the following trait bounds were not satisfied: `std::io::Stdout: tokio::io::AsyncWrite` which is required by `std::io::Stdout: tokio::io::AsyncWriteExt` = help: items from traits can only be used if the trait is in scope help: the following trait is implemented but not in scope; perhaps add a `use` for it: | 4 + use std::io::Write; |

Lints

could not compile `clightningrpc-plugin` (lib) due to 3 previous errors

Lints

Clippy had exited with the 101 exit code

single-character string constant used as pattern: plugin_macros/src/attr_parser.rs#L39

warning: single-character string constant used as pattern --> plugin_macros/src/attr_parser.rs:39:47 | 39 | let value = value.to_string().replace("\"", ""); | ^^^^ help: consider using a `char`: `'"'` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern = note: `#[warn(clippy::single_char_pattern)]` on by default

this `impl` can be derived: plugin_macros/src/plugin.rs#L61

warning: this `impl` can be derived --> plugin_macros/src/plugin.rs:61:1 | 61 | / impl Default for PluginDeclaration { 62 | | fn default() -> Self { 63 | | Self { 64 | | state: None, ... | 70 | | } 71 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls = note: `#[warn(clippy::derivable_impls)]` on by default = help: remove the manual implementation... help: ...and instead derive it | 9 + #[derive(Default)] 10 | pub struct PluginDeclaration { |

this expression creates a reference which is immediately dereferenced by the compiler: plugin_macros/src/plugin.rs#L45

warning: this expression creates a reference which is immediately dereferenced by the compiler --> plugin_macros/src/plugin.rs:45:47 | 45 | let mut inner = KTokenStream::new(&inner); | ^^^^^^ help: change this to: `inner` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

this expression creates a reference which is immediately dereferenced by the compiler: plugin_macros/src/plugin.rs#L30

warning: this expression creates a reference which is immediately dereferenced by the compiler --> plugin_macros/src/plugin.rs:30:47 | 30 | let mut inner = KTokenStream::new(&inner); | ^^^^^^ help: change this to: `inner` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default

Lints

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Lints

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

Lints

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Lints

Build (stable)

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Build (stable)

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

Build (stable)