Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Pasted image at" results hidden (black on black) on black theme #212

Open
vinzm opened this issue Mar 6, 2019 · 5 comments
Open

"Pasted image at" results hidden (black on black) on black theme #212

vinzm opened this issue Mar 6, 2019 · 5 comments

Comments

@vinzm
Copy link

vinzm commented Mar 6, 2019

Message "Pasted image at " etc results invisible (dark text on dark background) on the black theme.
Attached a couple of screenshot of the same portion w/ and w/o black theme.
image
image

@Otto42
Copy link

Otto42 commented Mar 7, 2019

Same thing for screenshots and such.

This seems to be a decent fix.

.c-message_kit__file__meta { 
color: #e6e6e6 
}

@vinzm
Copy link
Author

vinzm commented Mar 8, 2019

Thanks Otto42 for your reply.
Please forgive the newbie questions: is it a suggestion for other developers contributing to this project? Or is it a suggestion for me on how to work around it somehow? In the latter case I wouldn't know how to patch a remote and ajax-loaded css resource just for me...

mastermel added a commit that referenced this issue Mar 8, 2019
Refs #212

Test Plan:
- Find an image on the web, right-click it, select "Copy Image"
- Go to a channel or dm in Slack, use <cmd>+v to paste the image and
  upload it
- Verify that the meta text above the resulting image displayed in
  channel is in the correct theme color
@mastermel
Copy link
Collaborator

This should be corrected in the next theme release!

@vinzm
Copy link
Author

vinzm commented Mar 9, 2019

Sorry again for yet another newbie question: for what I can understand, no release was ever released (github says: 650 commits, 2 branches, 0 releases, 22 contributors); nevertheless I can use the theme (by pointing to black.css). So, what's the meaning of "in the next theme release"?

@vinzm
Copy link
Author

vinzm commented Mar 16, 2019

So, what's the meaning of "in the next theme release"?

Now it seems fixed.
As an attempt to answer to my question by myself, I guess what lets code-commits "go in production" is when someone pushes the css files built with such fixes to the repository.
Thanks everybody!

Zoooook pushed a commit to Zoooook/slack-night-mode that referenced this issue Jul 3, 2020
Refs laCour#212

Test Plan:
- Find an image on the web, right-click it, select "Copy Image"
- Go to a channel or dm in Slack, use <cmd>+v to paste the image and
  upload it
- Verify that the meta text above the resulting image displayed in
  channel is in the correct theme color
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants