Skip to content

[Doc][Misc] Clarify private-repo PR workflow and community PR rollback guidance #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
+5 −4
Closed

[Doc][Misc] Clarify private-repo PR workflow and community PR rollback guidance #4

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
127bc2e
Initial plan
Copilot Mar 11, 2026
374ec3f
docs: clarify private-repo PR workflow in AGENTS guide
Copilot Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,7 +378,7 @@ Before merging, verify:

- [ ] Commit messages are clear and descriptive, following Conventional Commits format
- [ ] **All commits are signed off** (`git commit -s`)
- [ ] PR is created from your fork repository, not directly from the main repository
- [ ] PR is created in your private repository (or private fork), not in the `vllm-project/vllm-ascend` community repository
- [ ] PR description is complete, following the PR template
- [ ] All review comments addressed

Expand All @@ -399,14 +399,15 @@ Before merging, verify:
bash format.sh ci
```
> **Note**: This check is required for **all file types**, including markdown files. If `markdownlint` modifies files, re-add them with `git add` and commit again.
10. Push to your fork repository (NOT the main repository):
10. Push to your private repository (or private fork):

```bash
git remote add myfork https://github.com/YOUR_USERNAME/vllm-ascend.git
git remote add myfork https://github.com/YOUR_USERNAME/vllm-ascend-dev.git
git push -u myfork your-branch-name
```

11. Create a PR from your fork to the main repository with clear description
11. Create a PR in your private repository (for example, from your branch to your repo default branch)
12. If you accidentally opened a PR in `vllm-project/vllm-ascend`, close that PR and reopen it in your private repository

---

Expand Down