Handle existing load balancer class #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Duplicate of l7mp/stunner#104 |
|
Sorry I missed the earlier bug report, thanks for referencing it. I wanted to update that we built and tested this in dev and rolled it out to our production clusters. And, it's been working reliably without the error log. Happy to try to figure out a test for this if you think it'd be worthwhile. |
|
Thanks a lot for the PR, we truly appreciate it that you made the effort! Don't worry about the duplicate: unfortunately some issues get reported to the STUNner repo and some issues here, and it's somewhat difficult to keep track of what's going on. |
rg0now
added a commit
that referenced
this pull request
Jan 3, 2024
fix: Open health-check service-port for LB Services only # Conflicts: # internal/renderer/service_util.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We frequently see an error like the following:
We're using the AWS load balancer controller, which sets that field when the service is created and handles the creation of a load balancer for us.
I traced this down to how the service gets recreated each time. We have a cache of the current state of the service in the global store, so we can use this to get the current values. We need to then be careful about adding ports, but other than that the change is pretty straightforward.