Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make library compatible with babashka. #145

Merged
merged 2 commits into from
Feb 21, 2022
Merged

Conversation

borkdude
Copy link
Contributor

@borkdude borkdude commented Feb 18, 2022

This PR makes cli-matic compatible with babashka. Fixes #113.

Changes:

  • Use java.time instead of SimpleDateFormat to parse a date.
  • Add bb.edn for running tests with babashka + cognitect test runner (also in CI).
  • To check availability of core.async, test using (require 'clojure.core.async.impl.channels): this specific namespace isn't exposed in bb so you cannot use it in this library for bb, but it should still work for JVM Clojure. It seems this impl namespace is only necessary for checking if something is a channel. I wonder if core.async could support that use case better.
  • Tests that didn't work with bb (yet) were marked with ^:skip-bb.
  • Upgrade YAML library to fix failing lein tests (unrelated to babashka).

@borkdude
Copy link
Contributor Author

/cc @nikvdp

@l3nz l3nz merged commit 80d9ebb into l3nz:master Feb 21, 2022
@l3nz l3nz mentioned this pull request Feb 21, 2022
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Ftr] Babashka compatibility
2 participants