Add vladisslav2011's EC hotpatch and battery fix deltas. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are those changes just parts of his patchset or they are substantially different to accommodate for the X2100? If it's the latter, having a distinct option for X2100 mode or forking the project altogether may make more sense to avoid confused users bricking their laptops. Anyway, i don't have a setup to unbrick my X210 in case of problems these days, so i'll wait until someone chimes in and tests it before merging. |
|
These changes are parts of his patchset, and are for X210. The |
mjg59
pushed a commit
to mjg59/x210-ec
that referenced
this pull request
Jan 1, 2021
mjg59
pushed a commit
to mjg59/x210-ec
that referenced
this pull request
Jan 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did an r2 bindiff on vladisslav2001's EC to port some of his fixes over to x2100. Here's the EC hotpatch delta, for use with his ec_sys.ko changes. Also enclosed is his battery bugfixes.
Note that I have NOT tested these changes, since I don't have an x210 board! So until someone tests this, use at your own risk. I've only tested my ported version on x2100.