ci: compile untested ancestor commits as minimal sanity-check - passing#106
Closed
ci: compile untested ancestor commits as minimal sanity-check - passing#106
Conversation
l0rinc
force-pushed
the
detached471-ci
branch
from
ac6b0a7 to
38dc4a5
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
l0rinc
force-pushed
the
detached471-ci
branch
from
38dc4a5 to
18899bc
Compare
l0rinc
changed the title
Extend `test-each-commit` to run on every non-head pull request commit.
The PR tip is excluded because it is already covered by other CI jobs.
Runner was changed to a performant cirrus runner.
Co-authored-by: MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>
l0rinc
force-pushed
the
detached471-ci
branch
from
18899bc to
5a2740c
Compare
fanquake
added a commit
to bitcoin/bitcoin
that referenced
this pull request
Feb 17, 2026
…nd fail fast eb510f8 ci: fail fast in test-each-commit script (Lőrinc) 04c4d71 ci: remove commit count limit from `test-each-commit` (Lőrinc) Pull request description: ### Problem `test-each-commit` currently tests only a limited number of ancestor commits in a PR, so failures introduced deeper in the commit stack might be missed. ### Fix Remove the max-count limit so `test-each-commit` runs the full build + unit + functional test flow on every non-head PR commit, while keeping the PR tip excluded because it is already covered by the normal CI jobs. It will also stop after the first failure to surface the root cause sooner and keep logs readable when testing ancestor commits. ### Examples * Example failure 10 commits deep: https://github.com/l0rinc/bitcoin/actions/runs/21390976651/job/61577575033?pr=105 in l0rinc#105 * Example pass with >7 dummy commits: https://github.com/l0rinc/bitcoin/actions/runs/21392557521/job/61595159841?pr=106 in l0rinc#106 --------- Note: this PR has gone through a few iterations, the latest one just extends the existing job. ACKs for top commit: maflcko: lgtm ACK eb510f8 🕓 hebasto: re-ACK eb510f8. willcl-ark: ACK eb510f8 Tree-SHA512: 5aadafd32daad610ce882277802c390642dc34f7d5bfa71d4b503ee007942d1ebafce2a3430ea5fd2af6673c83f9aee42450043be4722d7c02407d90920f8bce
l0rinc
commented
Mar 2, 2026
| name: 'test max 6 ancestor commits' | ||
| runs-on: ubuntu-24.04 | ||
| name: 'test ancestor commits' | ||
| needs: runners |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.