Ability to use custom DNS Servers #3
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I really don't know if this is a good feature or not. Regardless the current implementation leaves room for improvement.
The UI doesn't really feel polished. The "Add custom DNS Server" is on the bottom of the DNS Server list when no custom DNS Server is added and jumps to the top under the last custom DNS Server when there are ones.
This just feels wrong - I don't want to place a Button up top when there isn't something. An empty state would just use up screen real estate which - with the current design - is precious. But when the Custom DNS Servers aren't on the top they kind of lose their purpose. Nobody always wants to scroll to the bottom to view their own custom added servers.
The Edit button for a custom DNS Server just feels out of place.