This repository was archived by the owner on Feb 2, 2025. It is now read-only.
fix(#1691/#1692): remove dep to codelyzer#1697
Merged
Conversation
l-lin
force-pushed
the
fix/1691/remove_codelyzer_dependency
branch
from
0428ff1 to
fd257be
Compare
shanmukhateja
approved these changes
Dec 10, 2022
Collaborator
shanmukhateja
left a comment
shanmukhateja
left a comment
There was a problem hiding this comment.
The changes look good. Just hope it still builds and unit tests pass 😅
l-lin
changed the title
Collaborator
|
@l-lin can you make a new release once this is merged? I was thinking of a silent patch release (14.0.1). We also need to upgrade the library v15. I have been busy past few weeks balancing personal and work lives. |
Owner
Author
|
Unfortunately, I already released a v14.0.1 to test the nodejs bump in the github action. I will deprecate this 14.0.1 and release a 14.0.2. |
Collaborator
|
Sure, that works. Thanks for looking into this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix the issue on #1691 and #1692 as the codelyzer depends on angular 9, which may conflict with the project angular version.