-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
speedup function coordinate_to_string #106
Conversation
…_string((., inf))
…to_coordinate to same logic (precalculating mapping between column letters and column coordinate)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Mostly looks good, just a question about populating the lookup table.
Awesome, thanks again for the change! |
I wonder if the two definitions A and Z in Range are still needed or if they were only used for the functions that have been changed
|
Good catch, I think they can be removed. I don't foresee anyone passing |
Should I push again the branch with the changes? Or do you take this change in another PR? |
Already submitted the change :) |
as the function is used a lot when saving a Workbook, I have simplified it by using a lookup logic (mapping of column letters to column coordinates and vice versa) => 3x faster
I have also updated the function string_to_coordinate in the same spirit (avoid modulo calculation and use lookup)