Added Support for XLSM Files #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the binary file necessary for proper xlsm recognition and behavior when opening an xlsm file
Added xlsm-required attributes
Added jinja conditional statements to include vba-specific xml tags and properties
Added jinja conditional statements to include vba-specific xml tags and properties
Added jinja conditional statements to include vba-specific xml tags and properties
kevmo314
approved these changes
Nov 18, 2020
|
My pleasure, happy to help! Any idea on how long until this will be pushed to pypi for pip install? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #100
Summary of updated project resources:
vbaProject.binfile that contains the metadata for a vba project. Project was created with a single, empty function calledplaceholderin theThisWorkbookmodule. This is required for an xlsm file to produce the bin file when renaming an existing, valid xlsm file with macros to a zip file and extracting its contents.Workbook.pyto include ahas_macrosflag (and private/public class variable) that can be explicitly set only when calling theWorkbook.save()function. This way it's strictly "opt-in" behavior to include the added xml properties andvbaProject.binfile.[Content_Types].xml,workbook.xml, andsheet.xmlfiles to allow the file to properly recognized and opened by Excel.