Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add column sort order @ CreateIndexBuilder. #375

Merged
merged 17 commits into from
Apr 9, 2023

Conversation

igalklebanov
Copy link
Member

@igalklebanov igalklebanov commented Mar 21, 2023

closes #301.

This PR adds the ability to create sorted indexes in all built-in dialects, by simply adding asc/desc after column names.

Extra enhancement: can now chain multiple .column, .columns & .expression calls to append additional columns/expressions to index.

@igalklebanov igalklebanov added api Related to library's API enhancement New feature or request labels Mar 21, 2023
@igalklebanov igalklebanov marked this pull request as ready for review March 21, 2023 21:58
@igalklebanov igalklebanov added mysql Related to MySQL sqlite Related to sqlite postgres Related to PostgreSQL labels Mar 21, 2023
Copy link
Member

@koskimas koskimas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments, LGTM otherwise.

src/parser/reference-parser.ts Outdated Show resolved Hide resolved
src/parser/reference-parser.ts Outdated Show resolved Hide resolved
src/parser/reference-parser.ts Show resolved Hide resolved
@koskimas koskimas merged commit 22ec6d2 into kysely-org:master Apr 9, 2023
@igalklebanov igalklebanov deleted the create-index-sort branch April 9, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Related to library's API enhancement New feature or request mysql Related to MySQL postgres Related to PostgreSQL sqlite Related to sqlite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating a Sorted Index
2 participants