Support update table1, table2, ... query support. Closes #192

[koskimas]

Adds support for queries like this:

update
  person,
  pet
set
  person.first_name = ?,
  pet.name = ?
where
  person.id = pet.owner_id
  and person.name = ?

This kind of queries are supported by (at least) MySQL. As discussed in #192 we can't really make the join methods work with both MySQL and PostgreSQL since postgres joins add tables to the TB generic and MySQL would need to add to both UT and TB generics.

The set({ first_name: 'foo' }) version of the set method doesn't support table qualified references. The users need to use the set('table.column', value) version.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
kysely	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 14, 2024 11:52am

[koskimas]

I'm rebasing this to 0.28, but I think that branch is broken. The QueryNode.cloneWithEndModifier method is missing.

[igalklebanov]

I'm rebasing this to 0.28, but I think that branch is broken. The QueryNode.cloneWithEndModifier method is missing.

Yeah, it was 3 commits behind or something. I forgot to rebase it.

[koskimas]

I'm rebasing this to 0.28, but I think that branch is broken. The QueryNode.cloneWithEndModifier method is missing.

Yeah, it was 3 commits behind or something. I forgot to rebase it.

Actually, I just accidentally picked up the modifyEnd method when rebasing 😬

[igalklebanov]

Hey 👋

Overall LGTM as always! 🚀

I left some nitpicky comments..

I wonder if we could make set's object variant work for this scenario. Was it a type-complexity decision or something else?

[koskimas]

I wonder if we could make set's object variant work for this scenario. Was it a type-complexity decision or something else?

I'm afraid that auto-completion would lead postgres etc. users to use the table qualified names even though they only work on mysql. The object version already works for columns that are unambiguous. For example this works:

db.updateTable(['person', 'pet'])
  .set({ first_name: 'foo', name: 'bar' })

first_name is a person column and name is a pet column.