operation-node-transformer fixed: #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added copy of orderBy and limit properties in transformDeleteQuery - added copy of ifNotExists property in transformCreateSchema
koskimas
approved these changes
Jul 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was facing a bug when I was using createScheme. I miss the "if not exists" part of compiled query even I use ifNotExists method of CreateSchemaBuilder.
Then I do following fixes:
TEST_TRANSFORMER=1 npm run testfails)I've added create/drop schema tests too to prevent regression of this bug in future. Have to be tested with
TEST_TRANSFORMERenvironment variable set of course.Correct me if I'm wrong, SQLLite doesn't support schemas as other DBs do, right? I omit schema tests for it.