allow passing kysely instance to defineConfig.
#48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igalklebanov
force-pushed
the
config-pass-kysely-instance
branch
4 times, most recently
from
bd825e4 to
7a318b0
Compare
.. .. ..
igalklebanov
force-pushed
the
config-pass-kysely-instance
branch
from
cbd0d17 to
55ab1f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #47.
This PR makes it possible to pass a
kyselyinstance, instead of dialect name/instance, when needed*.This PR introduces typecheck tests using vitest to ensure
defineConfiginputs types don't break.*- when needed is also made clearer. A kysely/dialect is needed anytime both a seeder and a migrator are not passed.