Use hygiene from Span::call_site() to produce error messages#13
Merged
kyren merged 1 commit intokyren:masterfrom May 4, 2021
Merged
Use hygiene from Span::call_site() to produce error messages#13kyren merged 1 commit intokyren:masterfrom
Span::call_site() to produce error messages#13kyren merged 1 commit intokyren:masterfrom
Conversation
PR kyren#12 used `quote_spanned` to make error messages have the span of the corresponding field in the struct. However, there's no indication that the error comes from `#[derive(Collect)]`, which could be confusing for people unfamiliar with the crate. This PR uses `Span::resolved_at` to give the generated spans the hygiene information from the call site. This causes rustc to add a note about the error message originating from a macro, while still keeping the error message at the proper location.
Owner
|
As far as I can tell, this makes sense to me. I feel a bit unqualified to be reviewing it properly but I think it makes sense. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #12 used
quote_spannedto make error messages have the span of thecorresponding field in the struct. However, there's no indication that
the error comes from
#[derive(Collect)], which could be confusing forpeople unfamiliar with the crate.
This PR uses
Span::resolved_atto give the generated spans the hygieneinformation from the call site. This causes rustc to add a note about
the error message originating from a macro, while still keeping the
error message at the proper location.