So awesome add-ons controller #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mszostok
requested review from
bszwarc,
kazydek,
klaudiagrz and
tomekpapiernik
as code owners
mszostok
added
enhancement
area/monitoring
aszecowka
suggested changes
Feb 11, 2019
development/prow-addons-ctrl-manager/pkg/controller/notifier/notifier_controller.go
Show resolved
Hide resolved
development/prow-addons-ctrl-manager/pkg/controller/notifier/notifier_controller.go
Outdated
Show resolved
Hide resolved
development/prow-addons-ctrl-manager/pkg/controller/notifier/notifier_controller.go
Outdated
Show resolved
Hide resolved
development/prow-addons-ctrl-manager/pkg/controller/notifier/prowjob_controller_suite_test.go
Show resolved
Hide resolved
aszecowka
approved these changes
Feb 12, 2019
kazydek
reviewed
Feb 13, 2019
Co-Authored-By: mszostok <[email protected]>
kazydek
reviewed
Feb 13, 2019
kazydek
approved these changes
Feb 13, 2019
|
Just pls change this tiny one thing we talked about ;) |
Co-Authored-By: mszostok <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)