Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed parameter to test kaniko from pr. #12086

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Removed parameter to test kaniko from pr. #12086

merged 1 commit into from
Oct 7, 2024

Conversation

dekiel
Copy link
Contributor

@dekiel dekiel commented Oct 4, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • oci-image-builder config is stored together with pipeline. No need to instruct the tool to get it from PR on gh.com. Removing a flag which was used to signal oci-image-builder to use a config from pull request instead from main.

Related issue(s)
#10415

@dekiel dekiel requested review from neighbors-dev-bot and a team as code owners October 4, 2024 22:59
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 4, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 7, 2024
@Sawthis Sawthis assigned dekiel and unassigned Sawthis Oct 7, 2024
@kyma-bot kyma-bot merged commit 36d14dd into kyma-project:main Oct 7, 2024
60 checks passed
@dekiel dekiel deleted the remove-kaniko-config-from-pr branch October 7, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sawthis Sawthis Sawthis approved these changes

@neighbors-dev-bot neighbors-dev-bot Awaiting requested review from neighbors-dev-bot neighbors-dev-bot is a code owner

@szumejker szumejker Awaiting requested review from szumejker szumejker is a code owner automatically assigned from kyma-project/prow

Assignees

@dekiel dekiel

Labels
cla: yes Indicates the PR's author has signed the CLA. image-builder lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dekiel @Sawthis @kyma-bot