-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use pr default tag together with user provided tags #11981
Commits on Sep 25, 2024
-
Use config to provide a default tag for images build for pr or commit.
Added validation tag field to provide validation regex together with a tag. Update kaniko-build-config.yaml to provide default tag for pr and commit images with validation regex. Validating tag when parsing it's value. Added TagOption to add PR number to the Tagger instance. Using pull request default tag together with user provided tags instead replacing all values with default tag. This allows users to provide their own tag to the images build on pr.
Configuration menu - View commit details
-
Copy full SHA for 10a7926 - Browse repository at this point
Copy the full SHA 10a7926View commit details
Commits on Sep 27, 2024
-
Do not set base sha for pull request images.
Set only tagger fields needed for image type. Fix validation regex for commit to align with expected date format. Return error from TagOption to signal problems with setting it. Checking if pr or sha strings passed to TagOption is empty. Return error when trying to set empty string.
Configuration menu - View commit details
-
Copy full SHA for 38b93fb - Browse repository at this point
Copy the full SHA 38b93fbView commit details -
Use config to provide a default tag for images build for pr or commit.
Added validation tag field to provide validation regex together with a tag. Update kaniko-build-config.yaml to provide default tag for pr and commit images with validation regex. Validating tag when parsing it's value. Added TagOption to add PR number to the Tagger instance. Using pull request default tag together with user provided tags instead replacing all values with default tag. This allows users to provide their own tag to the images build on pr.
Configuration menu - View commit details
-
Copy full SHA for f300f20 - Browse repository at this point
Copy the full SHA f300f20View commit details -
Do not set base sha for pull request images.
Set only tagger fields needed for image type. Fix validation regex for commit to align with expected date format. Return error from TagOption to signal problems with setting it. Checking if pr or sha strings passed to TagOption is empty. Return error when trying to set empty string.
Configuration menu - View commit details
-
Copy full SHA for 18185fb - Browse repository at this point
Copy the full SHA 18185fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0252750 - Browse repository at this point
Copy the full SHA 0252750View commit details
Commits on Sep 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5c22071 - Browse repository at this point
Copy the full SHA 5c22071View commit details -
Merge remote-tracking branch 'refs/remotes/origin/custom-tag-on-pr' i…
…nto custom-tag-on-pr # Conflicts: # cmd/image-builder/main.go # pkg/tags/tag.go
Configuration menu - View commit details
-
Copy full SHA for aa62561 - Browse repository at this point
Copy the full SHA aa62561View commit details -
Aligned DateFormat TagOption to check for empty format string.
Added tests for options.
Configuration menu - View commit details
-
Copy full SHA for 2d509e9 - Browse repository at this point
Copy the full SHA 2d509e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for bf8c60a - Browse repository at this point
Copy the full SHA bf8c60aView commit details
Commits on Sep 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d01becb - Browse repository at this point
Copy the full SHA d01becbView commit details
Commits on Oct 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9a1a33b - Browse repository at this point
Copy the full SHA 9a1a33bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7da4a77 - Browse repository at this point
Copy the full SHA 7da4a77View commit details
Commits on Oct 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 67bc6d2 - Browse repository at this point
Copy the full SHA 67bc6d2View commit details