Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pr default tag together with user provided tags #11981

Merged
merged 13 commits into from
Oct 4, 2024

Commits on Sep 25, 2024

  1. Use config to provide a default tag for images build for pr or commit.

    Added validation tag field to provide validation regex together with a tag.
    Update kaniko-build-config.yaml to provide default tag for pr and commit images with validation regex.
    Validating tag when parsing it's value.
    Added TagOption to add PR number to the Tagger instance.
    Using pull request default tag together with user provided tags instead replacing all values with default tag. This allows users to provide their own tag to the images build on pr.
    dekiel committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    10a7926 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. Do not set base sha for pull request images.

    Set only tagger fields needed for image type.
    Fix validation regex for commit to align with expected date format.
    Return error from TagOption to signal problems with setting it.
    Checking if pr or sha strings passed to TagOption is empty. Return error when trying to set empty string.
    dekiel committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    38b93fb View commit details
    Browse the repository at this point in the history
  2. Use config to provide a default tag for images build for pr or commit.

    Added validation tag field to provide validation regex together with a tag.
    Update kaniko-build-config.yaml to provide default tag for pr and commit images with validation regex.
    Validating tag when parsing it's value.
    Added TagOption to add PR number to the Tagger instance.
    Using pull request default tag together with user provided tags instead replacing all values with default tag. This allows users to provide their own tag to the images build on pr.
    dekiel committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    f300f20 View commit details
    Browse the repository at this point in the history
  3. Do not set base sha for pull request images.

    Set only tagger fields needed for image type.
    Fix validation regex for commit to align with expected date format.
    Return error from TagOption to signal problems with setting it.
    Checking if pr or sha strings passed to TagOption is empty. Return error when trying to set empty string.
    dekiel committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    18185fb View commit details
    Browse the repository at this point in the history
  4. Adjusting tests

    dekiel committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    0252750 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2024

  1. Updated tests to verify changed features.

    Small fixes in application.
    dekiel committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    5c22071 View commit details
    Browse the repository at this point in the history
  2. Merge remote-tracking branch 'refs/remotes/origin/custom-tag-on-pr' i…

    …nto custom-tag-on-pr
    
    # Conflicts:
    #	cmd/image-builder/main.go
    #	pkg/tags/tag.go
    dekiel committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    aa62561 View commit details
    Browse the repository at this point in the history
  3. Aligned DateFormat TagOption to check for empty format string.

    Added tests for options.
    dekiel committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    2d509e9 View commit details
    Browse the repository at this point in the history
  4. Test getDefaultTag function.

    dekiel committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    bf8c60a View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. Configuration menu
    Copy the full SHA
    d01becb View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. Configuration menu
    Copy the full SHA
    9a1a33b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7da4a77 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. Configuration menu
    Copy the full SHA
    67bc6d2 View commit details
    Browse the repository at this point in the history