Skip to content

Commit

Permalink
Fix shellcheck issues
Browse files Browse the repository at this point in the history
  • Loading branch information
KacperMalachowski committed Sep 30, 2024
1 parent 8e10aa2 commit d0ef4f1
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 1 deletion.
Empty file removed cmd/jobguard/run.sh
Empty file.
3 changes: 3 additions & 0 deletions images/e2e-dind-k3d/init.sh
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
#!/usr/bin/dumb-init /bin/bash
# shellcheck shell=bash

set -e

Expand All @@ -12,6 +13,8 @@ cleanup_dind() {
fi
}

# It's called using trap for INT TERM signal
# shellcheck disable=SC2317
early_exit_handler() {
if [ -n "${WRAPPED_COMMAND_PID:-}" ]; then
kill -TERM "$WRAPPED_COMMAND_PID" || true
Expand Down
3 changes: 3 additions & 0 deletions images/e2e-dind-nodejs/init.sh
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
#!/usr/local/bin/dumb-init /bin/bash
# shellcheck shell=bash

set -e

Expand All @@ -12,6 +13,8 @@ cleanup_dind() {
fi
}

# It's called using trap for INT TERM signal
# shellcheck disable=SC2317
early_exit_handler() {
if [ -n "${WRAPPED_COMMAND_PID:-}" ]; then
kill -TERM "$WRAPPED_COMMAND_PID" || true
Expand Down
5 changes: 4 additions & 1 deletion images/unified-agent/start-wssagent.sh
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ GO_MOD_CONFIG_PATH="/wss/go-mod-wss-unified-agent.config"
JAVASCRIPT_CONFIG_PATH="/wss/javascript-wss-unified-agent.config"
PYTHON_CONFIG_PATH="/wss/python-wss-unified-agent.config"

if [[ ! -z "$INTERNAL_GITHUB_TOKEN" && ! -z "$INTERNAL_GITHUB_URL" ]]; then
if [[ -n "$INTERNAL_GITHUB_TOKEN" && -n "$INTERNAL_GITHUB_URL" ]]; then
git config --global url."https://${INTERNAL_GITHUB_TOKEN}:x-oauth-basic@${INTERNAL_GITHUB_URL}/".insteadOf "https://${INTERNAL_GITHUB_URL}/"
export GOPRIVATE=${INTERNAL_GITHUB_URL}/kyma
fi
Expand Down Expand Up @@ -99,6 +99,9 @@ function scanFolder() { # expects to get the fqdn of folder passed to scan
export WS_EXCLUDES="${WS_EXCLUDES} ${CUSTOM_EXCLUDE}"
fi

# WS_PRODUCTNAME is treat as a input
# it's set outside the script
# shellcheck disable=SC2153
echo "Product name - $WS_PRODUCTNAME"
echo "Project name - $WS_PROJECTNAME"

Expand Down

0 comments on commit d0ef4f1

Please sign in to comment.