feat: Keep all unexpired certs in istio-gatway-secret ca.crt#3033
Merged
lindnerby merged 13 commits intokyma-project:mainfrom Feb 8, 2026
Merged
Conversation
6 tasks
lindnerby
reviewed
Feb 6, 2026
Member
lindnerby
left a comment
There was a problem hiding this comment.
Just a few questions basically.
lindnerby
reviewed
Feb 6, 2026
6 tasks
Contributor
Author
|
@lindnerby FYI: noticed that there was a bug and fixed it fd55a8b Not detected by the unit test as the NotAfter was explicitly set to zero, but the NotBefore was also implicitly zero: bndlr := certificate.NewBundler(
certificate.WithParseX509Function(
func(_ []byte) (*x509.Certificate, error) {
return &x509.Certificate{
NotAfter: time.Time{},
}, nil
},
),
) |
c-pius
commented
Feb 6, 2026
lindnerby
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
bundler.gowith the functionality tohandler.goto use bundler adding for managing theistio-gateway-secretCA bundle (ca.crt)Related issue(s)