Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --docker-ports flag in order to expose custom ports when running with docker VM driver #645

Merged
merged 2 commits into from
Nov 17, 2020

Conversation

DimitarPetrov
Copy link
Member

Description

As of minikube v1.14 you can pass ports to expose when running minikube with docker driver.

This is a feature which we in compass was waiting in order to run locally with docker driver. This PR adopts that flag in kyma cli.

Reference: kubernetes/minikube#9404

@kyma-bot
Copy link

Hi @DimitarPetrov. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@netlify
Copy link

netlify bot commented Nov 16, 2020

🥰 Documentation preview ready! 🥰

Built with commit 0c7aa77

https://deploy-preview-645--kyma-project-cli-preview.netlify.app

@suleymanakbas91
Copy link

/test all

@clebs
Copy link
Contributor

clebs commented Nov 17, 2020

Hi @DimitarPetrov,
thanks a lot for your contribution! Your PR has been reviewed and tested.
I will now proceed to merge it.

@clebs clebs merged commit 4dc8853 into kyma-project:master Nov 17, 2020
@a-thaler a-thaler added this to the 1.18 milestone Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli Related to all activities around CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants