Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix: Add Indonesian and Malaysian Currency Transformer #173

Closed
wants to merge 3 commits into from

Conversation

ayrus02
Copy link

@ayrus02 ayrus02 commented Mar 22, 2024

Hi,
I just want to help the forgotten line of code for Indonesian Currency Transforme and Malaysian Currency Transformer

Add Indonesian Currency Transformer
Add Malaysian Currency Transformer
Add Indonesian Rupiah and Malaysian Ringgit to EnglishDictionary.php
Copy link
Owner

@kwn kwn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason why they were not included is that because they don't have the test cases, so there's no way for me to ensure they work fine.

Do you mind creating some test cases for both languages?

Additionally could you please extend the README.md file?

@kwn
Copy link
Owner

kwn commented Sep 18, 2024

Closing the PR. Feel free to reopen it with the unit tests attached.

@kwn kwn closed this Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants