verify query param length before adding them to the cache key

kwhitley · Mar 6, 2019 · 6ae593c · 6ae593c
1 parent 8337f16
commit 6ae593c
Showing 1 changed file with 16 additions and 10 deletions.
diff --git a/src/apicache.js b/src/apicache.js
@@ -420,18 +420,24 @@ function ApiCache() {
         key = url.parse(key).pathname
       }
 
-            // Remove blacklisted query params
+      // Remove blacklisted query params
       if (opt.queryParamsBlacklist.length > 0) {
         var queryParams = querystring.parse(url.parse(key).query)
-        var validQueryParams = Object.keys(queryParams)
-          .filter(function (key) {
-            return globalOptions.queryParamsBlacklist.indexOf(key) === -1
-          })
-          .reduce(function (acc, header) {
-            acc[header] = queryParams[header]
-            return acc
-          }, {})
-        key = url.parse(key).pathname + '?' + querystring.stringify(validQueryParams)
+        if (Object.keys(queryParams).length > 0) {
+          var validQueryParams = Object.keys(queryParams)
+            .filter(function(key) {
+              return globalOptions.queryParamsBlacklist.indexOf(key) === -1
+            })
+            .reduce(function(acc, header) {
+              acc[header] = queryParams[header]
+              return acc
+            }, {})
+
+          key = url.parse(key).pathname
+          if (Object.keys(validQueryParams).length > 0) {
+            key += '?' + querystring.stringify(validQueryParams)
+          }
+        }
       }
 
       // add appendKey (either custom function or response path)