Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve state_unsafe_mutation in getChatVar() #707

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

bangonicdd2
Copy link
Contributor

@bangonicdd2 bangonicdd2 commented Jan 6, 2025

PR Checklist

  • Have you checked if it works normally in all models? Ignore this if it doesn't use models.
  • Have you checked if it works normally in all web, local, and node hosted versions? If it doesn't, have you blocked it in those versions?
  • Have you added type definitions?

Description

While investigating an issue where {{getvar::A}} didn't work properly in background embedding, I encountered a state_unsafe_mutation error. It appears that modifying the null check operator on the relevant line can resolve this issue. Thank for your time.

@bangonicdd2
Copy link
Contributor Author

bangonicdd2 commented Jan 6, 2025

I also found another issue where the order flag in the regex script was not working as intended and included a fix in an additional commit.

@kwaroran kwaroran merged commit 9896b68 into kwaroran:main Jan 10, 2025
@bangonicdd2 bangonicdd2 mentioned this pull request Jan 17, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants