Skip to content

fix: replace unsupported Hrkt unicode property to Hira and Kana #705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 5, 2025

Conversation

Bo26fhmC5M
Copy link
Contributor

PR Checklist

  • Have you checked if it works normally in all models? Ignore this if it doesn't use models.
  • Have you checked if it works normally in all web, local, and node hosted versions? If it doesn't, have you blocked it in those versions?
  • Have you added type definitions?

Description

Auto Regenerate On Characterset feature can throw the following error when Hrkt is enabled:

Error while parsing chat message: true, Invalid regular expression: /\p{Script=Hrkt}/gu: Invalid property name

This PR fixes regex parsing issues with unicode property:

  1. Replaces unsupported Hrkt property with separate Hira and Kana properties
  2. Updates preview text for each property to match the changes

@kwaroran kwaroran merged commit 5c8adcb into kwaroran:main Jan 5, 2025
@Bo26fhmC5M Bo26fhmC5M deleted the patch-10 branch January 12, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants