Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This fixes build issues due upstream renames and upgrades #12

Merged
merged 1 commit into from
Nov 22, 2018
Merged

This fixes build issues due upstream renames and upgrades #12

merged 1 commit into from
Nov 22, 2018

Conversation

wolfeidau
Copy link
Contributor

  • Fix boltdb import -> go.etcd.io/bbolt
  • Fix etcd import -> go.etcd.io/etcd
  • Bumped underlying service versions in build
  • Bumped the golang version
  • Fix for golint

etcd-io/etcd#10044 (comment)

This fixes current build issues due upstream renames
f2bd412 
* Fix boltdb import -> go.etcd.io/bbolt
* Fix etcd import -> go.etcd.io/etcd
* Bumped underlying service versions in build
* Bumped the golang version
* Fix for golint

etcd-io/etcd#10044 (comment)
@coveralls
Copy link

Coverage Status

Coverage remained the same at 83.87% when pulling f2bd412 on wolfeidau:fix/build_dependencies into fc50db1 on abronan:master.

@wolfeidau wolfeidau changed the title This fixes current build issues due upstream renames This fixes build issues due upstream renames and upgrades Oct 18, 2018
vcastellm
vcastellm approved these changes Oct 18, 2018
View reviewed changes
Copy link

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wolfeidau wolfeidau mentioned this pull request Oct 19, 2018
Merged
@vcastellm
Copy link

Comments on this @mthenw @nmengin?

@vcastellm vcastellm merged commit 88d3244 into kvtools:master Nov 22, 2018
@vcastellm vcastellm mentioned this pull request Nov 30, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcastellm vcastellm vcastellm approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wolfeidau @coveralls @vcastellm