Skip to content

fix(bot-screen): restore configured screen size after human hand-back - #188

Open
kvnloo wants to merge 1 commit into
mainfrom
tip/125329-restore-screen-size-after-takeover
Open

kvnloo wants to merge 1 commit into
mainfrom
tip/125329-restore-screen-size-after-takeover

Conversation

@kvnloo

@kvnloo kvnloo commented Sep 27, 2026 •

Copy link
Copy Markdown
Owner

Tip leaf (fork-only diversify) — CLEAN

Closes #187

Maps origin tip NousResearch#125329 (not touched / not promoted).

What

After a human takes Bot Screen and leaves, Xvnc kept their resized geometry. On hand-back, restore bot_desktop.geometry (re-add the configured mode if Xvnc dropped it, then -s WxH).

Proof (fail→pass)

  • GREEN: tip product + tip tests → 5 passed (tests/tools/test_bot_desktop_geometry.py)
  • NEG: base product + tip tests → 5 failed (missing restore_geometry)
  • RESTORE: tip product restored → 5 passed

Notes

  • github_writes_origin=0 — kvnloo fork only
  • Codex promote: parked
  • Tip SHA (origin): d7ef7fc0621e43305324199af0e4fe90af292b84
  • Fork tip SHA: 4d3429fd019f1b80aef20b819cd263e8005b9f16

Credit / provenance

  • @Julientalbot authored upstream NousResearch/hermes-agent#125329; this downstream candidate mirrors/tests that work rather than claiming its underlying fix as new authorship.

@kvnloo kvnloo added the grok bot Posted by Grok Bot OSS review dump label Sep 27, 2026
@github-actions

github-actions Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

૮ >ﻌ< ა ci review

running on 4d3429f — fix(bot-screen): restore configured screen size after human


Still running 7 jobs: Desktop core E2E / Desktop core E2E (Linux), OS-specific tests / Windows E2E (real processes), OS-specific tests / Windows-only tests, OS-specific tests / Windows-only tests (arm64), Python tests / Run tests, Python tests / e2e, Python tests / e2e-upgrade

❌ Job failures

Check contributors / check-attribution · View job

Job Check contributors / check-attribution failed.


Python lints / Windows footguns (blocking) · View job

Job Python lints / Windows footguns (blocking) failed.


⚠️ Action required

Unmapped contributor email(s) · View job

New contributor email(s) are not in AUTHOR_MAP.

kvnloo@users.noreply.github.com (Kevin Rajan)

How to fix:

Run from the PR branch:

python3 scripts/audit_pr_attribution.py --fix
git add contributors && git commit -m "chore: map contributor emails" && git push

Or map one email manually (do NOT edit AUTHOR_MAP in scripts/releases/authors_legacy.py):

python3 scripts/add_contributor.py <email> <github-username>

To find the GitHub username for an email:

gh api 'search/users?q=EMAIL+in:email' --jq '.items[0].login'

kvnloo commented Sep 27, 2026

Copy link
Copy Markdown
Owner Author

Promoted the independent exact-head validation upstream: NousResearch#125329 (comment)

Keep this fork PR as durable evidence until origin disposition.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

grok bot Posted by Grok Bot OSS review dump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tip: restore Bot Screen size after human hand-back (#125329)

1 participant