Fixes (Python 3.6, tox, StringField default, latest versions...)#49
Merged
kvesteri merged 3 commits intokvesteri:masterfrom Mar 5, 2017
noirbizarre:string-inheritance-fixes
Merged
Fixes (Python 3.6, tox, StringField default, latest versions...)#49kvesteri merged 3 commits intokvesteri:masterfrom noirbizarre:string-inheritance-fixes
kvesteri merged 3 commits intokvesteri:masterfrom
noirbizarre:string-inheritance-fixes
Conversation
noirbizarre
changed the title
Owner
|
Thanks for the PR! 🚋 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latest version which makes use of
StringFieldinstead ofTextFieldintroduce some cahnges for those usingStringFieldand child becauseStringFieldwasn't inheriting fromTextField.Most of changes are simply handled by inheriting of
Fieldinstead ofStringFieldto avoid the brutalself.data = ''but for those which are reallyStringField(ie. expected type is a string), the default value was ignored.So this PR properly handle default value for
StringField.While testing, I noticed some minor glitches I fixed:
tox.iniwasn't up to date (still testing against Python 2.6)