Revert #426 and add support for Legacy Encrypted Type#450
Merged
kvesteri merged 5 commits intokvesteri:masterfrom May 24, 2020
Merged
Revert #426 and add support for Legacy Encrypted Type#450kvesteri merged 5 commits intokvesteri:masterfrom
kvesteri merged 5 commits intokvesteri:masterfrom
Conversation
Contributor
Author
|
Currently using @leosussan's code from this comment. |
Contributor
Author
|
|
rushilsrivastava
changed the title
Contributor
Author
|
CC @kvesteri, it looks like the linter is having problems with code that hasn't been modified. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to solve the problems outlined in #444 which were introduced in #426. The idea is to keep the old LargeBinary implementation and add a deprecated warning to it, as well as add support for the new
Stringimplementation forEncryptedType.