Add missing references to ik_llama.cpp #1116
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The modifications added in PR #754 by @moonshadow-25 were copied from ik_llama.cpp. The file iqk_mul_mat.inc to which the changes were added comes from the llamafile project, which just like KTRansformers itself is Apache-2.0 licensed. But the code copied from without attribution has been published under a MIT License.
I left a comment in PR #754 5 days ago, and also had this exchange with @moonshadow-25 3 days ago, which I think has given @moonshadow-25 enough time to correct the problem themself.
This PR corrects the problem created by @moonshadow-25 by adding links to the original source code in
ik_llama.cppalong with MIT copyright notices.As additional piece of information, user @godrosev, who is the author of the first two commits in PR #754, came to the ik_llama.cpp repository to ask for "1.58-bit" support with this issue. As I already had support for optimized
IQ1_Smatrix multiplications in row-interleaved format, I wasn't planning to also support plainIQ1_S, but then decided to help @godrosev, and added support in this PR.