Skip to content

Disable memcpy by default and improve stress workload test #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xiaguan merged 2 commits into from
Jul 2, 2025
Merged

Disable memcpy by default and improve stress workload test #577

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d589de6
Disable memcpy by default and improve stress workload test
xiaguan Jul 2, 2025
a82decf
fix comments
xiaguan Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions mooncake-store/src/transfer_task.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,10 +251,10 @@ TransferSubmitter::TransferSubmitter(TransferEngine& engine,
memcpy_pool_(std::make_unique<MemcpyWorkerPool>()) {
CHECK(!local_hostname_.empty()) << "Local hostname cannot be empty";

// Read MC_STORE_MEMCPY environment variable, default to true (enabled)
// Read MC_STORE_MEMCPY environment variable, default to false (disabled)
const char* env_value = std::getenv("MC_STORE_MEMCPY");
if (env_value == nullptr) {
memcpy_enabled_ = true; // Default: enabled
memcpy_enabled_ = false; // Default: disabled
} else {
std::string env_str(env_value);
// Convert to lowercase for case-insensitive comparison
Expand Down
5 changes: 2 additions & 3 deletions mooncake-store/tests/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,7 @@ target_link_libraries(stress_workload_test PUBLIC
cachelib_memory_allocator
${ETCD_WRAPPER_LIB}
glog
gtest
gtest_main
gflags
pthread
)

Expand All @@ -69,4 +68,4 @@ target_link_libraries(segment_test PUBLIC
)
add_test(NAME segment_test COMMAND segment_test)

add_subdirectory(e2e)
add_subdirectory(e2e)
Loading