Repository navigation
Conversation
An error callback can finish a partially submitted task while it remains on the QoS chain. The submit loop then completes it again when unlinking. Require the task to be off the chain before publishing completion and reclaiming it. (cherry picked from commit 6abce13)
cage-goat
requested review from
Aionw,
ShangmingCai,
UNIDY2002,
XucSh,
YiXR,
alogfans,
staryxchen,
stmatengss and
ykwd
as code owners
October 27, 2026 09:35
Discover preconnected namespaces from sysfs and submit aligned block I/O through O_DIRECT and io_uring. Reuse the existing NoF workers and QoS, with queue-backpressure retry and separate probe contexts that retain in-flight buffers through timeout and teardown. Add Linux-only build and runtime selection without SPDK or hugepage requirements, while preserving the existing SPDK backend. Document Linux backend deployment and connection ownership.
cage-goat
force-pushed
the
feat/linux-nof-initiator
branch
from
October 29, 2026 02:25
918e4fa to
8ef1282
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Building on the NoF initiator interface introduced in #3424, this PR adds a Linux kernel NVMe-oF backend for client data I/O and master heartbeat probes. It reuses the kernel's connection management capabilities and supports deployment without SPDK/DPDK or hugepages.
Fixes #5001
Main changes:
O_DIRECTandio_uring, reusing the existing NoF workers and QoS.io_uringqueue for each namespace to prevent busy namespaces from exhausting a shared queue and reduce interference between namespaces.Connection setup and reconnection are managed by the operating system and deployment tools. The current implementation supports one connected controller per subsystem on each host. If a device is deleted or recreated, the affected Mooncake processes must be restarted.
Suggested Merge Priority
Module
mooncake-transfer-engine)mooncake-store)mooncake-conductor)mooncake-reshard)mooncake-ep)mooncake-pg)mooncake-integration)mooncake-p2p-store)mooncake-wheel)mooncake-common)mooncake-rl)Type of Change
How Has This Been Tested?
Validated with a Linux-only build using
USE_NOF=ON,USE_NOF_LINUX=ON,USE_NOF_SPDK=OFF, andBUILD_UNIT_TESTS=ON.Test commands:
Test results:
Unit tests cover endpoint parsing, device discovery, NoF workers, and heartbeat handling. The E2E test verifies real writes, reads, and payload consistency against a temporary NVMe/TCP target.
Additional network fault testing on Linux 6.17.1, with unlimited reconnection, a 10-second KATO, and
fast_io_fail_tmo=30, verified that:Fault testing covers the Linux initiator and probe API, not the complete Store segment removal and re-registration workflow. Final-commit regression verification remains pending.
Performance testing
Validated the Linux initiator in a real NVMe/RDMA environment. The single-NS test accessed one namespace in one subsystem through a single 200 Gbit/s network port. The dual-NS test used two independent subsystems, each containing one namespace and accessed through a dedicated 200 Gbit/s network port, for an aggregate link bandwidth of 400 Gbit/s.
The logical I/O size was 1 MiB, with a 256 KiB submission chunk size and 256 KiB random LBA alignment. Single-NS random read/write throughput reached 22.77/22.68 GiB/s, while dual-NS aggregate throughput reached 44.81/45.05 GiB/s—approximately 98%–100% of the fio baseline measured in the same environment.
The tests used two additional benchmark-only changes that are not included in this PR:
Checklist
./scripts/code_format.shAI Assistance Disclosure
Codex assisted with implementation, testing, code review, and documentation.
The human submitter is responsible for understanding and defending all changes.