Repository navigation
[Bugfix][Store] Exit standalone master without destroying the object index - #4865
huangxiaobai-ydmy wants to merge 1 commit into
Conversation
…index On SIGTERM, skip walking metadata_shards_ via ExitAfterShutdown after stopping RPC, admin, worker pool, and HTTP metadata (kvcache-ai#4856). (Rebased onto main after kvcache-ai#5030; packaging commits dropped.)
4b7cb16 to
29bc657
Compare
Same packaging gap as kvcache-ai#5006/kvcache-ai#5007/kvcache-ai#4865 after kvcache-ai#3954.
|
Previous |
|
Thanks for picking up the |
|
Thanks @staryxchen — agreed. Will wait for #5030 to land, then rebase onto |
|
#5030 is now on |
59f34c0 to
a8926f9
Compare
|
Thanks @staryxchen — rebased onto |
Description
Fixes #4856.
Standalone (non-HA)
mooncake_masterpreviously returned frommain()after SIGTERM/SIGINT, so destructors walkedmetadata_shards_object-by-object. At 12M–25M objects that took ~20–48 s after the RPC server had already stopped, delaying Kubernetes rollouts; the index is not reused across a restart after the legacy snapshot removal.This change matches the HA shutdown path since #4745:
ExitAfterShutdown(0)so the object index is reclaimed by the kernel without a user-space walk.Standalone has no etcd lease to revoke; the HTTP metadata server is stopped explicitly before
_exit.Suggested Merge Priority
Module
mooncake-store)Type of Change
How Has This Been Tested?
Test commands:
Test results:
ExitAfterShutdownpath; destructor audit for non-HA external effects)Checklist
./scripts/code_format.shAI Assistance Disclosure
Cursor AI assisted with issue analysis against #4856 / HA #4745, implementing the non-HA
ExitAfterShutdownpath, and PR drafting. The submitter reviewed the changes.