Repository navigation
[Store] Support DFS-only KV benchmarks and expand usage guide - #4798
Merged
Merged
Conversation
ykwd
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Store KV benchmark rejects configurations with zero memory and NoF replicas, even when a DFS replica is requested. Allow DFS-only placement while continuing to reject configurations with all replica counts set to zero.
read_perf,verify_write, andmixed_rw, using plain/zcopy APIs and single/batch requests.This follows the Store's DFS-only placement support merged in #4637. Related PR #4645 changes lane-startup cleanup in the same benchmark files; this PR changes replica validation and documentation, without modifying that cleanup path or the DFS adapter implementation.
Suggested Merge Priority
Module
mooncake-store)Type of Change
How Has This Been Tested?
Test commands:
Test results:
USE_3FS=ON.The live matrix covered POSIX and native HF3FS USRBIO, memory+DFS and DFS-only placement, plain/zcopy APIs, and
verify_write/read_perf. Each case used two worker lanes, wrote nine 64 KiB objects, and verified nine reads, with zero misses or verification failures.verify_writeused single-object requests;read_perfused batches of up to four objects, including a final partial batch.Client logs confirmed DFS reads for DFS-only placement and memory selection for memory+DFS placement. These were functional smoke tests, not performance measurements. The local smoke harness, build artifacts, and logs are excluded from the PR.
Checklist
C/C++ formatting and an architectural RFC are not applicable.
AI Assistance Disclosure
OpenAI Codex assisted with implementation, documentation, regression tests, and local validation. The human submitter reviewed the changes.