Skip to content

[Store] Disarm the persistent write-failure injector before the reuse retry in dfs_sync_client_test #4785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
he-yufeng wants to merge 1 commit into from
Closed

[Store] Disarm the persistent write-failure injector before the reuse retry in dfs_sync_client_test #4785

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions mooncake-store/tests/dfs_sync_client_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -630,6 +630,11 @@ TEST_F(DfsSyncClientTest, DfsOnlyBatchFailureOnlyRevokesFailedKey) {
ExpectDfsOnlyValue(keys[0], values[0]);
ExpectNotFound(keys[1]);

// The injector fails every write once armed (a persistent fault, which
// is what defeats the backend's reopen-retry above). Disarm it before
// the retry: the transient fault is modeled as cleared once the failed
// key has been revoked, otherwise the reuse Put can never succeed.
adapter_->FailWriteCall(-1);
// The revoked key and its extent can be reused.
std::vector<Slice> retry{{values[1].data(), values[1].size()}};
ASSERT_TRUE(writer_->Put(keys[1], retry, DfsOnlyConfig()).has_value());
Expand Down
Loading