Skip to content

[Store][Bugfix] Fix DFS sync client test retry failure #4781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stmatengss merged 1 commit into from
Oct 20, 2026
Merged

[Store][Bugfix] Fix DFS sync client test retry failure #4781

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions mooncake-store/tests/dfs_sync_client_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,17 +31,13 @@ class FailingPosixFsAdapter : public PosixFsAdapter {
public:
int WriteCalls() const { return write_calls_.load(); }
void FailWriteCall(int call) { fail_write_call_.store(call); }
void ClearWriteFailure() { fail_write_call_.store(-1); }

tl::expected<size_t, ErrorCode> WriteAt(int fd, const iovec* iov,
int iovcnt,
int64_t offset) override {
const int call = ++write_calls_;
const int fail = fail_write_call_.load();
// Model a genuine, non-recoverable write failure: once the armed call
// is reached, keep failing. The backend retries POSIX write failures
// once after an fd reopen (SupportsFdReopen), so a single-call failure
// would be masked by the retry; a persistent failure correctly
// surfaces to the caller.
if (fail > 0 && call >= fail) {
return tl::make_unexpected(ErrorCode::FILE_WRITE_FAIL);
}
Expand Down Expand Up @@ -623,6 +619,7 @@ TEST_F(DfsSyncClientTest, DfsOnlyBatchFailureOnlyRevokesFailedKey) {
adapter_->FailWriteCall(adapter_->WriteCalls() + 2);

auto results = writer_->BatchPut(keys, slices, DfsOnlyConfig());
adapter_->ClearWriteFailure();
ASSERT_EQ(results.size(), keys.size());
EXPECT_TRUE(results[0].has_value());
ASSERT_FALSE(results[1].has_value());
Expand Down
Loading