Repository navigation
[Bugfix] Pass a lease policy from the BatchProbe DSL step - #4742
kunkunblueberry wants to merge 1 commit into
Conversation
kvcache-ai#4314 changed MasterService::BatchProbeKey to take a GrantLeasePolicy, but the MasterScenario DSL kept calling the two-argument form, so master_service_test_dsl no longer compiles and every PR's CTest job fails while building the tests. Pass GrantLeasePolicy{} (lease_mode None), which the implementation maps to the lease-free existence probe the DSL step relied on before, so the scenario behavior is unchanged.
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
|
Heads up: this exact fix already landed via #4729 (merged), which changed the same Could you rebase onto current main and check whether anything remains? If the DSL step builds clean now, this can probably be closed; if you intended the DSL to thread a real (non-default) lease policy from |
|
Thanks @he-yufeng — confirmed, #4729 landed the same call-site fix ( |
Description
maincurrently does not build its test tree: #4314 changedMasterService::BatchProbeKeyto take aGrantLeasePolicy, but theMasterScenarioDSL kept calling the two-argument form, somaster_service_test_dslfails to compile and every PR'sCTest unit testsjob dies while building the tests (verified on two unrelated PRs: #4736 and #4741, both failing atdsl/scenario.cpp:1926withno matching function for call to BatchProbeKey(std::vector<std::string>&, TenantId)).This is a one-call-site fix: pass
GrantLeasePolicy{}, i.e.lease_mode = None. The implementation maps that toBatchExistKeyImpl(..., grant_lease=false), which is exactly the lease-free existence probe the DSL step relied on before the signature change, so scenario behavior is unchanged.Verified by building the affected target (
master_service_test_dsl) — it links after the fix.Suggested Merge Priority
Module
mooncake-transfer-engine)mooncake-store)mooncake-conductor)mooncake-reshard)mooncake-ep)mooncake-pg)mooncake-integration)mooncake-p2p-store)mooncake-wheel)mooncake-common)mooncake-rl)Type of Change
How Has This Been Tested?
Test commands:
Test results:
Checklist
./scripts/code_format.shAI Assistance Disclosure
Found and fixed with AI assistance; the human submitter reviewed the change and the reasoning for
GrantLeasePolicy{}preserving prior behavior.