Skip to content

[Bugfix][TransferEngine] Enable TCP connection pooling by default #4464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
guptaishaan wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Bugfix][TransferEngine] Enable TCP connection pooling by default #4464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mooncake-transfer-engine/include/transport/tcp_transport/tcp_transport.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ class TcpTransport : public Transport {
TcpContext *context_;
std::atomic_bool running_;
std::thread thread_;
bool enable_connection_pool_ = false;
bool enable_connection_pool_ = true;

// Client-side bounded work queues and fixed connection lanes.
struct ConnectionKey {
Expand Down
14 changes: 8 additions & 6 deletions mooncake-transfer-engine/tests/tcp_write_visibility_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,7 +411,10 @@ class ScopedEnvVar {
had_old_value_ = true;
old_value_ = old;
}
setenv(name_.c_str(), value, 1);
if (value)
setenv(name_.c_str(), value, 1);
else
unsetenv(name_.c_str());
}

~ScopedEnvVar() {
Expand Down Expand Up @@ -914,10 +917,8 @@ struct EngineHandle {

void init(const std::string& metadata_server,
const std::string& server_name, size_t pool_size) {
// Exercise the pooled-connection path (default off): connection
// reuse vs. discard-on-unclean-exchange is part of the contract
// under test.
setenv("MC_TCP_ENABLE_CONNECTION_POOL", "1", 1);
// Connection reuse vs. discard-on-unclean-exchange is part of the
// contract under test.
engine = std::make_unique<TransferEngine>(false);
auto hp = parseHostNameWithPort(server_name);
int rc = engine->init(metadata_server, server_name, hp.first.c_str(),
Expand Down Expand Up @@ -2285,10 +2286,11 @@ TEST(TcpWriteVisibilityTest, LaneTerminalTypesAreMoveOnly) {
}
#endif

TEST(TcpWriteVisibilityTest, OneLaneReusesCleanSocketInFifoOrder) {
TEST(TcpWriteVisibilityTest, DefaultConnectionPoolReusesCleanSocket) {
constexpr int kRequestCount = 8;
constexpr size_t kLength = 64 * 1024;
constexpr size_t kPoolSize = kRequestCount * kLength;
ScopedEnvVar pooling("MC_TCP_ENABLE_CONNECTION_POOL", nullptr);
ScopedEnvVar lanes("MC_TCP_LANES_PER_PEER", "1");
ScopedEnvVar queue_capacity("MC_TCP_MAX_QUEUED_TRANSFERS_PER_PEER", "16");
const char* env = std::getenv("MC_METADATA_SERVER");
Expand Down
Loading