Repository navigation
[CI/Build] Publish ROCm nightly wheels to TestPyPI - #4266
Merged
Merged
Conversation
Signed-off-by: andyluo7 <andy.luo@amd.com>
andyluo7
requested review from
Aionw,
Ann-1024,
luketong777,
stmatengss and
ykwd
as code owners
September 21, 2026 22:58
stmatengss
approved these changes
Sep 22, 2026
Collaborator
|
@Aionw Could you double-check? |
Aionw
added a commit
to Aionw/Mooncake
that referenced
this pull request
Sep 28, 2026
Conflict resolution: - .github/CODEOWNERS: kept both sides. The /python/mooncake/pg.py and /python/tests/pg/ entries stay grouped after /python/tests/ep/ (same owners), followed by main's /python/tests/services/test_http_metadata_server.py entry from kvcache-ai#3632. All other files merged cleanly. .github/workflows/ci_rocm.yml now matches main (including kvcache-ai#4266's setup-python change).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Mooncake's scheduled nightly workflow already builds ROCm wheels for Python 3.10 and 3.12, but those artifacts are neither stamped with the computed nightly version nor included in the TestPyPI upload.
This change:
This complements #4265, which rejects ROCm wheels built without multi-protocol routing. The PRs are independent: #4265 guards wheel correctness, while this PR makes validated development wheels available through the existing nightly TestPyPI channel.
Related roadmap: #3556.
Overlap: #3970 also edits ci_rocm.yml and nightly.yml as part of a broader packaging-backend migration, but it does not publish ROCm nightly wheels. If #3970 lands first, this small change will need to be rebased onto its root-package version override.
Deployment prerequisite: the existing TESTPYPI_API_TOKEN in the nightly environment must be authorized to create or upload the currently absent mooncake-transfer-engine-rocm TestPyPI project.
Module
Type of Change
How Has This Been Tested?
Test commands:
Test results:
Results: 7/7 CI-script tests and 6/6 TestPyPI gate tests passed. The scoped pre-commit suite and workflow syntax validation passed. Native ROCm wheel builds and TestPyPI publication require upstream CI and repository credentials and were not run locally.
Checklist
AI Assistance Disclosure
OpenAI Codex inspected the existing nightly, ROCm build, integration, and publication workflows; implemented the scoped workflow changes and regression tests; and ran the validation commands listed above. The human submitter remains responsible for reviewing every changed line and for the TestPyPI credential configuration.