Skip to content

[Store] Release GIL during client setup #3947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ykwd merged 1 commit into from
Sep 10, 2026
+19 −9
Merged

[Store] Release GIL during client setup #3947

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 19 additions & 9 deletions mooncake-integration/store/store_py.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2194,12 +2194,17 @@ PYBIND11_MODULE(store, m) {
transfer_engine =
engine.cast<std::shared_ptr<TransferEngine>>();
}
return real_client->setup_real(
local_hostname, metadata_server, global_segment_size,
local_buffer_size, protocol, rdma_devices,
master_server_addr, transfer_engine, "", enable_ssd_offload,
ssd_offload_path, tenant_id, enable_client_http_server,
client_http_port);
int ret;
{
py::gil_scoped_release release;
ret = real_client->setup_real(
local_hostname, metadata_server, global_segment_size,
local_buffer_size, protocol, rdma_devices,
master_server_addr, transfer_engine, "",
enable_ssd_offload, ssd_offload_path, tenant_id,
enable_client_http_server, client_http_port);
}
return ret;
},
py::arg("local_hostname"), py::arg("metadata_server"),
py::arg("global_segment_size"), py::arg("local_buffer_size"),
Expand All @@ -2222,9 +2227,14 @@ PYBIND11_MODULE(store, m) {
config[key] = value;
}

auto result = real_client->setup_internal(config);
return result.has_value() ? 0
: static_cast<int>(result.error());
int ret;
{
py::gil_scoped_release release;
auto result = real_client->setup_internal(config);
ret = result.has_value() ? 0
: static_cast<int>(result.error());
}
return ret;
},
py::arg("config"),
"Setup the store with a configuration dictionary.\n"
Expand Down
Loading