Repository navigation
Conversation
bitborne
requested review from
XucSh,
YiXR,
stmatengss and
ykwd
as code owners
August 31, 2026 18:27
ykwd
approved these changes
Sep 1, 2026
1 task done
Signed-off-by: Schatten <czhengt@qq.com>
bitborne
force-pushed
the
store/registered-pinned-memory-environ-convergence
branch
from
September 1, 2026 09:01
1bc6620 to
1e5cd0d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Move the startup-only
MC_STORE_PIN_MEMORY_MAX_BYTESsetting out of theregistered pinned-memory manager and into a dedicated
RegisteredPinnedMemoryConfig.behavior;
parsing the environment itself.
Module
mooncake-transfer-engine)mooncake-store)mooncake-reshard)mooncake-ep)mooncake-pg)mooncake-integration)mooncake-p2p-store)mooncake-wheel)mooncake-common)mooncake-rl)Type of Change
How Has This Been Tested?
Test commands:
cmake --build build --target registered_pinned_memory_test -j32 ctest --test-dir build -R '^registered_pinned_memory_test$' --output-on-failure pre-commit run --files \ mooncake-common/include/environment_variables.h \ mooncake-store/src/config/registered_pinned_memory_config.h \ mooncake-store/src/config/registered_pinned_memory_config.cpp \ mooncake-store/src/registered_pinned_memory.h \ mooncake-store/src/registered_pinned_memory.cpp \ mooncake-store/src/CMakeLists.txt \ mooncake-store/tests/registered_pinned_memory_test.cppTest results:
Checklist
./scripts/code_format.shAI Assistance Disclosure
Codex helped trace the existing environment semantics, implement the refactor,
add focused tests, and run formatting and review checks. I reviewed the
changes and test results.