Repository navigation
[Store] Add batch OpLog snapshot coordinator - #3794
Merged
Merged
Conversation
Icedcoco
marked this pull request as ready for review
September 1, 2026 02:16
Icedcoco
requested review from
00fish0,
Aionw,
Libotry,
XucSh,
YiXR,
stmatengss and
ykwd
as code owners
September 1, 2026 02:16
1 task
ykwd
approved these changes
Sep 1, 2026
11 of 14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR-N06 adds the standalone
BatchOpLogSnapshotCoordinatorfor the new batch OpLog standby snapshot path. It composes the existing N02 capture, N03 artifact writer, N04 maintenance lease/publisher, and N05 standby cursor state into one coordinator with periodic scheduling and explicit lifecycle state.The coordinator is inert when only
HotStandbyServiceis constructed. It is not wired into public configuration or the default production path; N08 will perform that integration after the complete snapshot mode is ready.Scheduling and lifecycle
<batch-id>-<lease-id>candidate prefix and reuses the existing chunk writer and fenced publisher.Compatibility
ha/snapshot/batch_oplog/namespace, with only a compatibility include at the snapshot root.Module
mooncake-store)Type of Change
How Has This Been Tested?
Test commands:
Test results:
The coordinator test passed 2/2 tests. Existing batch snapshot writer passed 6/6, provider 5/5, publisher 12/13 with the real-etcd case skipped because no local etcd endpoint was available, and HotStandbyService passed 31 tests with 14 existing etcd-dependent cases skipped.
Checklist
./scripts/code_format.shThe implementation follows the PR-N06 snapshot coordinator design spec; add the corresponding RFC/issue link here if the maintainer requires one for this development branch.
AI Assistance Disclosure
The human submitter must review every changed line and be able to explain and defend the coordinator lifecycle, promotion/stop behavior, lease fencing, and test coverage.