[982945902]

Description

TransferEngineImpl::freeLocalMemory() removed an allocation from allocated_memory_ even when the owning transport returned an error. The memory could remain allocated while the engine permanently lost the ownership record, so callers could not retry the release.

This change commits the ownership removal only after the transport reports a successful free. A fail-once transport regression test verifies that the first error preserves the allocation, the second call reaches the transport and succeeds, and a later call is correctly rejected after ownership has been released.

Module

• Transfer Engine (mooncake-transfer-engine)

Type of Change

• Bug fix

How Has This Been Tested?

Test commands:

cmake --build /workspaces/build --target \
  tent_local_memory_lifecycle_test tent_runtime_queue_dispatch_test -j8
/workspaces/build/tests/tent_local_memory_lifecycle_test
/workspaces/build/tests/tent_runtime_queue_dispatch_test

Test results:

• Unit tests pass
• Integration tests pass (if applicable)
• Manual testing done: before the fix, a fail-once transport was called only once and the retry returned Address region not registered; the regression test now observes two transport free calls and a successful retry.

Checklist

• I have performed a self-review of my own code
• I have formatted my code using ./scripts/code_format.sh
• I have run pre-commit on the files changed in this PR and all hooks pass
• I have updated the documentation (if applicable)
• I have added tests to prove my changes are effective
• For changes >500 LOC: I have filed an RFC issue

pre-commit is not installed in the available development image; git diff --check and the PR-scoped C++ formatting script pass.

AI Assistance Disclosure

• AI tools were used (specify below)

Codex helped identify and reproduce the ownership-loss path, implement the success-only ownership commit, and add the fail-once regression test. The human submitter should review and understand every changed line before merge.

[alogfans]

Advise to prints warning.

[982945902]

Added a warning before returning the transport error. It includes the address, allocation size, and original status while preserving the ownership entry for a later retry. Fixed in ce87244.

[alogfans]

LGTM