Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't build vangers v0.3.0 (rustc 1.80.0 (051478957 2024-07-21)) #243

Closed
caiiiycuk opened this issue Aug 3, 2024 · 3 comments
Closed

Can't build vangers v0.3.0 (rustc 1.80.0 (051478957 2024-07-21)) #243

caiiiycuk opened this issue Aug 3, 2024 · 3 comments

Comments

@caiiiycuk
Copy link
Contributor

I trying to run tool for word -> obj conversion with following command:

cargo run --release --bin convert -- /x/games/Vangers\ RU/game/thechain/fostral/world.ini tmp/fostral.obj

Whenever I do this I have a lot of errors like this:

error: unnecessary qualification
  --> src/render/water.rs:93:35
   |
93 |             size: (max_vertices * mem::size_of::<Vertex>()) as wgpu::BufferAddress,
   |                                   ^^^^^^^^^^^^^^^^^^^^^^
   |
help: remove the unnecessary path segments
   |
93 -             size: (max_vertices * mem::size_of::<Vertex>()) as wgpu::BufferAddress,
93 +             size: (max_vertices * size_of::<Vertex>()) as wgpu::BufferAddress,

I understand that this is a lint error. I tried lot of ways to disable it, but nothing works for me. Please point me how to workaround this.

Last thing I tried that should work, but didn't:

RUSTFLAGS="-A unused_qualifications" cargo run --release --bin convert -- /x/games/Vangers\ RU/game/thechain/fostral/world.ini tmp/fostral.obj
@caiiiycuk
Copy link
Contributor Author

1.68.0, 1.75.0 - compile without problems

@kvark
Copy link
Owner

kvark commented Aug 3, 2024

Whoa, did Rust just included size_of in the prelude? I wonder how to properly set up the lint in this case.
Could you replace "mem::size_of" by "size_of" locally?
I'm on nixOS where getting latest Rust is a bit of a pain.

caiiiycuk added a commit to caiiiycuk/vange-rs that referenced this issue Aug 5, 2024
@kvark
Copy link
Owner

kvark commented Aug 6, 2024

Should be fixed in 74e61d5

@kvark kvark closed this as completed Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants