Fix Quaternion memory layout #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Quaternion memory layout is now `[x, y, z, w]` (i.e. scalar at the end). This is consistent with the `Into` trait implementation and also consistent with other libraries (such as GLM) and the GLTF spec. Fixes kvark#49
kvark
approved these changes
Dec 27, 2019
|
@kvark I don't think bors is hooked up (based on your previous comments on another PR) |
I think this is a breaking change iff sufficiently strong guarantees are asserted by the documentation to permit nontrivial sound |
|
Is there any downside to bumping the minor version? EDIT: Ah, I saw this before I saw it was released. Nevermind about the version! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Quaternion memory layout is now
[x, y, z, w](i.e. scalar at the end). This is consistent with theIntotrait implementation and also consistent with other libraries (such as GLM) and the GLTF spec.Fixes #49