Skip to content

fix: print error in non interactive termianl #2850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tedim52 merged 4 commits into from
Dec 11, 2025
Merged

fix: print error in non interactive termianl #2850

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
88e438c
only send msg for interactive terminal
tedim52 Nov 28, 2025
5f7aa95
add var
tedim52 Nov 28, 2025
4ad0217
print err and final output in non interactive
tedim52 Dec 10, 2025
7d8d9e9
Merge branch 'main' into tedi/noninteractive
tedim52 Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions cli/cli/helpers/output_printers/parallel_kurtosis_instruction_printer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@ type ParallelExecutionPrinter struct {
errorMsgOutput string // gets populated if error occurs during execution
finalOutput string // gets populated after execution is complete
programDone chan struct{} // used to wait for the bubbletea program to finish and signal when to print the final output

isInteractive bool
}

func NewParallelExecutionPrinter() *ParallelExecutionPrinter {
Expand All @@ -46,6 +48,7 @@ func NewParallelExecutionPrinter() *ParallelExecutionPrinter {
errorMsgOutput: "",
finalOutput: "",
programDone: make(chan struct{}),
isInteractive: interactive_terminal_decider.IsInteractiveTerminal(),
}
}

Expand All @@ -54,7 +57,7 @@ func (printer *ParallelExecutionPrinter) Start() error {
return stacktrace.NewError("printer already started")
}
printer.isStarted = true
if !interactive_terminal_decider.IsInteractiveTerminal() {
if !printer.isInteractive {
logrus.Infof("Kurtosis CLI is running in a non interactive terminal. Everything will work but progress information and the progress bar will not be displayed.")
return nil
}
Expand Down Expand Up @@ -89,7 +92,16 @@ func (printer *ParallelExecutionPrinter) Stop() {
if !printer.isStarted {
return
}
if !interactive_terminal_decider.IsInteractiveTerminal() {

if !printer.isInteractive {
if printer.errorMsgOutput != "" {
out.PrintOutLn(printer.errorMsgOutput)
}

if printer.finalOutput != "" {
out.PrintOutLn(printer.finalOutput)
}

printer.isStarted = false
return
}
Expand Down Expand Up @@ -199,7 +211,7 @@ func (printer *ParallelExecutionPrinter) PrintKurtosisExecutionResponseLineToStd
Info: formatInfo(info.GetInfoMessage()),
}
}
if msg != nil {
if msg != nil && printer.isInteractive {
select {
case printer.bubbleteaMsgChan <- msg:
default:
Expand Down
Loading